[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 8/8] audio: Fix using freed pointer in wav_fini_out(
From: |
arei.gonglei |
Subject: |
[Qemu-devel] [PATCH 8/8] audio: Fix using freed pointer in wav_fini_out() |
Date: |
Tue, 27 May 2014 09:40:05 +0800 |
From: Gonglei <address@hidden>
Spotted by Coverity:
(8) Event freed_arg: "fclose(FILE *)" frees "wav->f".
(9) Event cond_true: Condition "fclose(wav->f)", taking true branch
Also see events: [pass_freed_arg]
212 if (fclose (wav->f)) {
(10) Event pass_freed_arg: Passing freed pointer "wav->f" as an argument
to function "AUD_log(char const *, char const *, ...)".
Also see events: [freed_arg]
213 dolog ("wav_fini_out: fclose %p failed\nReason: %s\n",
214 wav->f, strerror (errno));
Removed wav->f's pointer in error log, actually it's uselessly.
Signed-off-by: Gonglei <address@hidden>
---
audio/wavaudio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/audio/wavaudio.c b/audio/wavaudio.c
index 6846a1a..9bbe8e9 100644
--- a/audio/wavaudio.c
+++ b/audio/wavaudio.c
@@ -210,8 +210,8 @@ static void wav_fini_out (HWVoiceOut *hw)
doclose:
if (fclose (wav->f)) {
- dolog ("wav_fini_out: fclose %p failed\nReason: %s\n",
- wav->f, strerror (errno));
+ dolog ("wav_fini_out: fclose 'wav->f' failed\nReason: %s\n",
+ strerror (errno));
}
wav->f = NULL;
--
1.7.12.4
[Qemu-devel] [PATCH 1/8] vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16, 24, 32}, arei.gonglei, 2014/05/26
- Re: [Qemu-devel] [PATCH 1/8] vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16, 24, 32}, Paolo Bonzini, 2014/05/27
- Re: [Qemu-devel] [PATCH 1/8] vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16, 24, 32}, Gonglei (Arei), 2014/05/28
- Re: [Qemu-devel] [PATCH 1/8] vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16, 24, 32}, Paolo Bonzini, 2014/05/28
- Re: [Qemu-devel] [PATCH 1/8] vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16, 24, 32}, Gonglei (Arei), 2014/05/28
[Qemu-devel] [PATCH 8/8] audio: Fix using freed pointer in wav_fini_out(),
arei.gonglei <=
[Qemu-devel] [PATCH 4/8] qcow2-cluster: Fix memory leak in copy_sectors, arei.gonglei, 2014/05/26
[Qemu-devel] [PATCH 5/8] qemu-bridge-helper: Fix fd leak in main(), arei.gonglei, 2014/05/26