[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_dir
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory() |
Date: |
Tue, 27 May 2014 13:02:28 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Monday 26 May 2014 à 19:37:13 (+0200), Markus Armbruster wrote :
> Has always been leaky. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block/vvfat.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 2c82a5c..389704a 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -787,7 +787,9 @@ static int read_directory(BDRVVVFATState* s, int
> mapping_index)
> s->current_mapping->path=buffer;
> s->current_mapping->read_only =
> (st.st_mode & (S_IWUSR | S_IWGRP | S_IWOTH)) == 0;
> - }
> + } else {
> + g_free(buffer);
> + }
> }
> closedir(dir);
Reviewed-by: Benoit Canet <address@hidden>
>
> --
> 1.9.3
>
>
- Re: [Qemu-devel] [PATCH 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths, (continued)
- [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 01/14] qemu-img: Plug memory leak on block option help error path, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Markus Armbruster, 2014/05/26