[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert com
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert command |
Date: |
Tue, 27 May 2014 13:04:24 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Monday 26 May 2014 à 19:37:15 (+0200), Markus Armbruster wrote :
> Introduced in commit 661a0f7. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 62ea27e..d118da5 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -1455,7 +1455,7 @@ static int img_convert(int argc, char **argv)
> ret = bdrv_parse_cache_flags(cache, &flags);
> if (ret < 0) {
> error_report("Invalid cache option: %s", cache);
> - return -1;
> + goto out;
> }
>
> out_bs = bdrv_new_open("target", out_filename, out_fmt, flags, true,
> quiet);
> --
> 1.9.3
>
>
Reviewed-by: Benoit Canet <address@hidden>
- [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, (continued)
- [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert command, Markus Armbruster, 2014/05/26
- Re: [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert command,
Benoît Canet <=
- [Qemu-devel] [PATCH 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 01/14] qemu-img: Plug memory leak on block option help error path, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Markus Armbruster, 2014/05/26
- Re: [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Kevin Wolf, 2014/05/28