[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] arm: Bugfix: Fix cpu_reset() / vcpu_init() order
From: |
Christoffer Dall |
Subject: |
[Qemu-devel] [PATCH v2] arm: Bugfix: Fix cpu_reset() / vcpu_init() order |
Date: |
Tue, 27 May 2014 14:22:08 +0200 |
Commit 50a2c6e55fa introduced a bug where QEMU would segfault on startup
when using KVM on ARM hosts, because kvm_arm_reset_cpu() accesses
cpu->cpreg_reset_values, which is not allocated before
kvm_arch_init_vcpu(). Fix this by not calling cpu_reset() until after
qemu_init_vcpu().
Acked-by: Paolo Bonzini <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Christoffer Dall <address@hidden>
---
Changes since v1:
- Updated commit message (current version by Peter Maydell)
target-arm/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-arm/cpu.c b/target-arm/cpu.c
index 6c6f2b3..794dcb9 100644
--- a/target-arm/cpu.c
+++ b/target-arm/cpu.c
@@ -370,8 +370,8 @@ static void arm_cpu_realizefn(DeviceState *dev, Error
**errp)
init_cpreg_list(cpu);
- cpu_reset(cs);
qemu_init_vcpu(cs);
+ cpu_reset(cs);
acc->parent_realize(dev, errp);
}
--
1.8.5.2
- [Qemu-devel] [PATCH v2] arm: Bugfix: Fix cpu_reset() / vcpu_init() order,
Christoffer Dall <=