[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] arm: Bugfix: Fix cpu_reset() / vcpu_init() o
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] arm: Bugfix: Fix cpu_reset() / vcpu_init() order |
|
Date: |
Tue, 27 May 2014 14:33:07 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Am 27.05.2014 14:22, schrieb Christoffer Dall:
> Commit 50a2c6e55fa introduced a bug where QEMU would segfault on startup
> when using KVM on ARM hosts, because kvm_arm_reset_cpu() accesses
> cpu->cpreg_reset_values, which is not allocated before
> kvm_arch_init_vcpu(). Fix this by not calling cpu_reset() until after
> qemu_init_vcpu().
>
> Acked-by: Paolo Bonzini <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Christoffer Dall <address@hidden>
> ---
> Changes since v1:
> - Updated commit message (current version by Peter Maydell)
You missed updating the subject line. ;) That said,
Reviewed-by: Andreas Färber <address@hidden>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg