Re: [Qemu-devel] [PATCH 3/8] json-parser: fix two coverity defects

[Paolo Bonzini]

Il 27/05/2014 03:40, address@hidden ha scritto:
> t *ctxt, va_list *ap)
>          }
>          token = NULL;
>      } else {
> -        token = parser_context_pop_token(ctxt);
> -        token = NULL;
> +        (void)parser_context_pop_token(ctxt);
>      }
>
>      return QOBJECT(dict);
> @@ -542,8 +541,7 @@ static QObject *parse_array(JSONParserContext *ctxt, 
> va_list *ap)
>
>          token = NULL;
>      } else {
> -        token = parser_context_pop_token(ctxt);
> -        token = NULL;
> +        (void)parser_context_pop_token(ctxt);
>      }
>
>      return QOBJECT(list);

You used to have 2 dead stores, now you have 4. :)  Please remove all 
the token = NULL assignments.

Paolo