qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/8] smbus: Fix unreachable code in smb_transact

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 6/8] smbus: Fix unreachable code in smb_transaction()
Date: Tue, 27 May 2014 17:15:47 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 
Il 27/05/2014 17:09, Gerd Hoffmann ha scritto:

> >      default:
> >          goto error;
> >      }
> > -    abort();

>
> This is intentional defensive programming.  A "break" from the switch
> would be wrong, hence the "abort" here.

Could be replaced with a "g_assert_notreach()" to make that more clear?


Sure.

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]