Re: [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory()

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 05/26/2014 11:37 AM, Markus Armbruster wrote:
>> Has always been leaky.  Spotted by Coverity.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  block/vvfat.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/block/vvfat.c b/block/vvfat.c
>> index 2c82a5c..389704a 100644
>> --- a/block/vvfat.c
>> +++ b/block/vvfat.c
>> @@ -787,7 +787,9 @@ static int read_directory(BDRVVVFATState* s, int 
>> mapping_index)
>>          s->current_mapping->path=buffer;
>>          s->current_mapping->read_only =
>>              (st.st_mode & (S_IWUSR | S_IWGRP | S_IWOTH)) == 0;
>> -    }
>> +    } else {
>
> Looks odd to have TAB here,
>
>> +            g_free(buffer);
>> +        }
>
> but not here

I'll expand the tab when I respin.  Thanks!