qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts
Date: Tue, 27 May 2014 21:48:57 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/07/2014 03:58 AM, Chunyan Liu wrote:
> vvfat shares create options of qcow driver. To avoid vvfat breaking when
> qcow driver changes from QEMUOptionParameter to QemuOpts, let it able
> to handle both cases.
> 
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
> Change:
>   * Fix memory free:
>     - qemu_opts_free(create_opts);
>     + if (bdrv_qcow->create_options) {
>     +     qemu_opts_free(create_opts);
>     + }
> 
>  block/vvfat.c | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]