Re: [Qemu-devel] [PULL 00/33] Block patches

[Stefan Hajnoczi]

On Tue, May 27, 2014 at 06:15:29PM +0100, Peter Maydell wrote:
> On 23 May 2014 16:41, Stefan Hajnoczi <address@hidden> wrote:
> > The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a:
> >
> >   Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into 
> > staging (2014-05-22 19:04:49 +0100)
> >
> > are available in the git repository at:
> >
> >
> >   git://github.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to 1c53366b9589b5438336dce86d6ffea35bf80b15:
> >
> >   block/sheepdog: Don't use qerror_report() (2014-05-23 17:39:26 +0200)
> 
> This pullreq seems to introduce extra noise into "make check":
> 
> GTESTER tests/test-qemu-opts
> There is no option group 'unknown'
> 
> Either that should be a test failure or it shouldn't be
> outputting anything.

The output is intended, perhaps its a sign that we should plumb through
Error* instead of using error_report().

tests/test-qemu-opts.c:test_find_unknown_opts() invokes
qemu_find_opts("unknown") to check that NULL is returned.

qemu_find_opts() does this:

  ret = find_list(vm_config_groups, group, &local_err);
  if (local_err) {
      error_report("%s", error_get_pretty(local_err));

This is the source of the message.

Either we remove this test case or we modify the QEMU code.

Stefan