Re: [Qemu-devel] [RFC PATCH] trace: Replace error with warning if event is not defined

[Lluís Vilanova]

Stefan Hajnoczi writes:

> On Wed, May 21, 2014 at 06:16:01PM +1000, Alexey Kardashevskiy wrote:
>> At the moment QEMU exits if trace point is not defined which makes
>> a developer life harder if he has to switch between branches with
>> different traces implemented.
>> 
>> This replaces error+exit wit WARNING if the tracepoint does not exist or
>> not traceable.
>> 
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>> ---
>> 
>> 
>> That would make my life easier indeed. Thanks :)
>> 
>> 
>> ---
>> trace/control.c | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)

> Thanks, applied to my tracing tree:
> https://github.com/stefanha/qemu/commits/tracing

I was doing some silly tests with "error_report". Would it be worth to port all
these printfs to it?

It also makes it prettier to see, for example, what line in the event list file
failed when executing 'trace_init_events'.


Thanks,
  Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth