qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 10/11] block: add backing-file option to bloc


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 10/11] block: add backing-file option to block-stream
Date: Wed, 28 May 2014 06:47:00 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/27/2014 08:28 AM, Jeff Cody wrote:
> On some image chains, QEMU may not always be able to resolve the
> filenames properly, when updating the backing file of an image
> after a block job.
> 

> +++ b/hmp-commands.hx
> @@ -76,7 +76,7 @@ ETEXI
>  
>      {
>          .name       = "block_stream",
> -        .args_type  = "device:B?,speed:o?,base:s?,base-node-name:s?",
> +        .args_type  = 
> "device:B?,speed:o?,base:s?,base-node-name:s?,backing-file:s?",
>          .params     = "device [speed [base]]",

Another HMP change that is probably better with a named optional
parameter (backing-file:+f or some such), rather than positional.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]