[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/13] softmmu: make do_unaligned_access a metho
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/13] softmmu: make do_unaligned_access a method of CPU |
|
Date: |
Wed, 28 May 2014 20:24:02 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Am 28.05.2014 20:17, schrieb Paolo Bonzini:
> Il 28/05/2014 19:20, Andreas Färber ha scritto:
>>> +void alpha_cpu_do_unaligned_access(CPUState *cs, vaddr addr,
>>> + int is_write, int is_user,
>>> uintptr_t retaddr)
>>> {
>>> - AlphaCPU *cpu = alpha_env_get_cpu(env);
>>> - CPUState *cs = CPU(cpu);
>>> + AlphaCPU *cpu = ALPHA_CPU(cs);
>
> What's the standard variable name for XyzCPU?
"cpu", no objections there. The assumption is that the specific type
will be used more often and should thus have the more natural name.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 04/13] softmmu: start introducing SOFTMMU_CODE_ACCESS in softmmu_header.h, (continued)
- [Qemu-devel] [PATCH 04/13] softmmu: start introducing SOFTMMU_CODE_ACCESS in softmmu_header.h, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 03/13] hw: use ld_p/st_p instead of ld_raw/st_raw, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 06/13] softmmu: move definition of CPU_MMU_INDEX to inclusion site, drop ACCESS_TYPE, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 05/13] softmmu: move MMUSUFFIX under SOFTMMU_CODE_ACCESS, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 08/13] softmmu: move ALIGNED_ONLY to cpu.h, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 07/13] softmmu: make do_unaligned_access a method of CPU, Paolo Bonzini, 2014/05/23
[Qemu-devel] [PATCH 09/13] softmmu: commonize helper definitions, Paolo Bonzini, 2014/05/23
[Qemu-devel] [PATCH 10/13] softmmu: move softmmu_template.h out of include/, Paolo Bonzini, 2014/05/23
[Qemu-devel] [PATCH 11/13] target-arm: move arm_*_code to a separate file, Paolo Bonzini, 2014/05/23
[Qemu-devel] [PATCH 12/13] softmmu: introduce cpu_ldst.h, Paolo Bonzini, 2014/05/23
[Qemu-devel] [PATCH 13/13] softmmu: move all load/store functions to cpu_ldst.h, Paolo Bonzini, 2014/05/23