|
| From: | Max Reitz |
| Subject: | Re: [Qemu-devel] [PATCH v2 10/10] block: Avoid bdrv_get_geometry() where errors should be detected |
| Date: | Wed, 28 May 2014 23:27:34 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 28.05.2014 16:25, Markus Armbruster wrote:
bdrv_get_geometry() hides errors. Use bdrv_nb_sectors() or bdrv_getlength() instead where that's obviously inappropriate. Signed-off-by: Markus Armbruster <address@hidden> --- block.c | 11 ++++++++--- block/qapi.c | 14 ++++++++++---- qemu-img.c | 59 +++++++++++++++++++++++++++++++++++++++++++++-------------- 3 files changed, 63 insertions(+), 21 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
| [Prev in Thread] | Current Thread | [Next in Thread] |