Re: [Qemu-devel] [PATCH] target-arm/cpu64.c: Actually register Cortex-A57 impdef registers

[Peter Crosthwaite]

On Wed, May 28, 2014 at 7:30 AM, Peter Maydell <address@hidden> wrote:
> cpu64.c contains a reginfo list for the impdef registers on
> the Cortex-A57; however we forgot to actually call define_arm_cp_regs(),
> so it was sitting there doing nothing. Remedy this omission.
>
> Signed-off-by: Peter Maydell <address@hidden>

I have this locally in my tree. You beat me to the post. So I guess:

Reviewed-by: Peter Crosthwaite <address@hidden>
Tested-by: Peter Crosthwaite <address@hidden>

Regards,
Peter

> ---
>  target-arm/cpu64.c | 1 +
>  1 file changed, 1 insertion(+)
>
> Oops. clang 3.4 warns about the unused variable (along with
> a lot of similar issues in other parts of the codebase).
> Linux doesn't actually look at any of the A57 impdef regs,
> or we'd have noticed this earlier.
>
> diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c
> index 8daa622..ff4c2b4 100644
> --- a/target-arm/cpu64.c
> +++ b/target-arm/cpu64.c
> @@ -128,6 +128,7 @@ static void aarch64_a57_initfn(Object *obj)
>      cpu->ccsidr[1] = 0x201fe012; /* 48KB L1 icache */
>      cpu->ccsidr[2] = 0x70ffe07a; /* 2048KB L2 cache */
>      cpu->dcz_blocksize = 4; /* 64 bytes */
> +    define_arm_cp_regs(cpu, cortexa57_cp_reginfo);
>  }
>
>  #ifdef CONFIG_USER_ONLY
> --
> 1.9.2
>
>