[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure |
|
Date: |
Fri, 30 May 2014 10:21:04 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Igor Mammedov <address@hidden> writes:
> On Thu, 29 May 2014 10:41:32 -0600
> Eric Blake <address@hidden> wrote:
>
>> On 05/27/2014 07:01 AM, Igor Mammedov wrote:
[...]
>> > + goto out;
>> > + }
>> > + if (!value) {
>> > + error_setg(&local_err, "Property '%s.%s' doesn't take value '%"
>> > + PRIu64 "'", object_get_typename(obj), name , value);
>>
>> No space before comma.
> there is no space before comma and there shouldn't be one since it's an end of
> an argument.
Look again, at the comma separating the last two arguments.
[Qemu-devel] [PATCH v3 04/34] vl.c: daemonize before guest memory allocation, Igor Mammedov, 2014/05/27
[Qemu-devel] [PATCH v3 06/34] vl.c: extend -m option to support options for memory hotplug, Igor Mammedov, 2014/05/27
[Qemu-devel] [PATCH v3 01/34] machine: Conversion of QEMUMachineInitArgs to MachineState, Igor Mammedov, 2014/05/27
[Qemu-devel] [PATCH v3 07/34] pc: create custom generic PC machine type, Igor Mammedov, 2014/05/27
[Qemu-devel] [PATCH v3 09/34] qdev: expose DeviceState.hotplugged field as a property, Igor Mammedov, 2014/05/27
[Qemu-devel] [PATCH v3 08/34] qdev: hotplug for buss-less devices, Igor Mammedov, 2014/05/27
[Qemu-devel] [PATCH v3 10/34] dimm: implement dimm device abstraction, Igor Mammedov, 2014/05/27