Re: [Qemu-devel] [PATCH v2 11/20] qcow2: Handle failure for potentially large allocations

[Stefan Hajnoczi]

On Wed, May 28, 2014 at 04:37:44PM +0200, Kevin Wolf wrote:
> Some code in the block layer makes potentially huge allocations. Failure
> is not completely unexpected there, so avoid aborting qemu and handle
> out-of-memory situations gracefully.
> 
> This patch addresses the allocations in the qcow2 block driver.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qcow2-cache.c    | 12 +++++++++++-
>  block/qcow2-cluster.c  | 35 +++++++++++++++++++++++++++--------
>  block/qcow2-refcount.c | 46 ++++++++++++++++++++++++++++++++++++----------
>  block/qcow2-snapshot.c | 22 +++++++++++++++++-----
>  block/qcow2.c          | 41 +++++++++++++++++++++++++++++++++--------
>  5 files changed, 124 insertions(+), 32 deletions(-)

Thanks for addressing my comments.

Modulo Max's comments:

Reviewed-by: Stefan Hajnoczi <address@hidden>