Re: [Qemu-devel] [RFC 4/5] qmp: add query-acpi-ospm-status command

[Igor Mammedov]

On Fri, 30 May 2014 09:22:56 -0600
Eric Blake <address@hidden> wrote:

> On 05/28/2014 08:57 AM, Igor Mammedov wrote:
> > ... to get ACPI OSPM status reported by ACPI devices
> > via _OST method.
> > 
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> >  qapi-schema.json |    9 +++++++++
> >  qmp-commands.hx  |   22 ++++++++++++++++++++++
> >  qmp.c            |   20 ++++++++++++++++++++
> >  3 files changed, 51 insertions(+), 0 deletions(-)
> 
> Interface review:
> 
> 
> > +Example:
> > +-> { "execute": "query-acpi-ospm-status" }
> > +<- { 'return': [ { 'device': 'd1', 'slot': 0, 'source': 1, 'status': 0},
> 
> Should 'status' be represented as an enum type, rather than an
> open-coded integer?
it takes values from ACPI spec, which potentially could be anything
in 32bit range, it would be better to stick to spec.

> 
> > +                 { 'device': '', 'slot': 1, 'source': 0, 'status': 0},
> > +                 { 'device': '', 'slot': 2, 'source': 0, 'status': 0},
> 
> Why not make 'device' optional, and omit it when there is no associated
> device string?
Could you point to an example of an optional field?
 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 


-- 
Regards,
  Igor