Re: [Qemu-devel] [PULL 6/8] machine: Make -machine opts properties of MachineState

[Eduardo Habkost]

On Wed, May 28, 2014 at 07:29:01PM +0200, Andreas Färber wrote:
[...]
> +static void machine_initfn(Object *obj)
> +{
> +    object_property_add_str(obj, "accel",
> +                            machine_get_accel, machine_set_accel, NULL);
> +    object_property_add_bool(obj, "kernel_irqchip",
> +                             machine_get_kernel_irqchip,
> +                             machine_set_kernel_irqchip,
> +                             NULL);
> +    object_property_add(obj, "kvm_shadow_mem", "int",
> +                        machine_get_kvm_shadow_mem,
> +                        machine_set_kvm_shadow_mem,
> +                        NULL, NULL, NULL);
> +    object_property_add_str(obj, "kernel",
> +                            machine_get_kernel, machine_set_kernel, NULL);
> +    object_property_add_str(obj, "initrd",
> +                            machine_get_initrd, machine_set_initrd, NULL);
> +    object_property_add_str(obj, "append",
> +                            machine_get_append, machine_set_append, NULL);
> +    object_property_add_str(obj, "dtb",
> +                            machine_get_dtb, machine_set_dtb, NULL);
> +    object_property_add_str(obj, "dumpdtb",
> +                            machine_get_dumpdtb, machine_set_dumpdtb, NULL);
> +    object_property_add(obj, "phandle_start", "int",
> +                        machine_get_phandle_start,
> +                        machine_set_phandle_start,
> +                        NULL, NULL, NULL);
> +    object_property_add_str(obj, "dt_compatible",
> +                            machine_get_dt_compatible,
> +                            machine_set_dt_compatible,
> +                            NULL);
> +    object_property_add_bool(obj, "dump-guest-core",
> +                             machine_get_dump_guest_core,
> +                             machine_set_dump_guest_core,
> +                             NULL);
> +    object_property_add_bool(obj, "mem-merge",
> +                             machine_get_mem_merge, machine_set_mem_merge, 
> NULL);
> +    object_property_add_bool(obj, "usb", machine_get_usb, machine_set_usb, 
> NULL);
> +    object_property_add_str(obj, "firmware",
> +                            machine_get_firmware, machine_set_firmware, 
> NULL);
> +}

The "kvm-type" option was left out.

I don't have a ppc machine where I can test it, but it looks like this
makes the kvm-type option unusable, as
  qemu_opt_foreach(machine_opts, object_set_property, current_machine, 1)
will now fail.

-- 
Eduardo