[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/8] qdev: add qdev_alias_all_properties()
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/8] qdev: add qdev_alias_all_properties() |
Date: |
Sat, 31 May 2014 08:17:56 +1000 |
On Fri, May 30, 2014 at 9:17 PM, Stefan Hajnoczi <address@hidden> wrote:
> The qdev_alias_all_properties() function creates QOM alias properties
> for each qdev property on a DeviceState. This is useful for parent
> objects that wish to forward property accesses to their children.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
> ---
> v3:
> * Split qdev_alias_all_properties() into its own patch [Peter Crosthwaite]
> * Do not dereference DEVICE_CLASS(class) inline [Peter Crosthwaite]
> ---
> hw/core/qdev.c | 21 +++++++++++++++++++++
> include/hw/qdev-properties.h | 2 ++
> 2 files changed, 23 insertions(+)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index e65a5aa..850cd9e 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -776,6 +776,27 @@ void qdev_property_add_static(DeviceState *dev, Property
> *prop,
> }
> }
>
> +/* @qdev_alias_all_properties - Add alias properties to the source object for
> + * all qdev properties on the target DeviceState.
> + */
> +void qdev_alias_all_properties(DeviceState *target, Object *source)
> +{
> + ObjectClass *class;
> + Property *prop;
> +
> + class = object_get_class(OBJECT(target));
> + do {
> + DeviceClass *dc = DEVICE_CLASS(class);
> +
> + for (prop = dc->props; prop && prop->name; prop++) {
> + object_property_add_alias(source, prop->name,
> + OBJECT(target), prop->name,
> + &error_abort);
> + }
> + class = object_class_get_parent(class);
> + } while (class != object_class_by_name(TYPE_DEVICE));
> +}
> +
> static bool device_get_realized(Object *obj, Error **errp)
> {
> DeviceState *dev = DEVICE(obj);
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index c46e908..ffef425 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -192,6 +192,8 @@ void error_set_from_qdev_prop_error(Error **errp, int
> ret, DeviceState *dev,
> */
> void qdev_property_add_static(DeviceState *dev, Property *prop, Error
> **errp);
>
> +void qdev_alias_all_properties(DeviceState *target, Object *source);
> +
> /**
> * @qdev_prop_set_after_realize:
> * @dev: device
> --
> 1.9.3
>
>
- [Qemu-devel] [PATCH v3 0/8] virtio-blk: use alias properties in transport devices, Stefan Hajnoczi, 2014/05/30
- [Qemu-devel] [PATCH v3 2/8] virtio-blk: avoid qdev property definition duplication, Stefan Hajnoczi, 2014/05/30
- [Qemu-devel] [PATCH v3 1/8] qom: add object_property_add_alias(), Stefan Hajnoczi, 2014/05/30
- [Qemu-devel] [PATCH v3 3/8] virtio-blk: move x-data-plane qdev property to virtio-blk.h, Stefan Hajnoczi, 2014/05/30
- [Qemu-devel] [PATCH v3 4/8] qdev: add qdev_alias_all_properties(), Stefan Hajnoczi, 2014/05/30
- Re: [Qemu-devel] [PATCH v3 4/8] qdev: add qdev_alias_all_properties(),
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v3 6/8] virtio-blk: drop virtio_blk_set_conf(), Stefan Hajnoczi, 2014/05/30
- [Qemu-devel] [PATCH v3 5/8] virtio-blk: use aliases instead of duplicate qdev properties, Stefan Hajnoczi, 2014/05/30
- [Qemu-devel] [PATCH v3 8/8] virtio-blk: move qdev properties into virtio-blk.c, Stefan Hajnoczi, 2014/05/30
- [Qemu-devel] [PATCH v3 7/8] virtio: fix virtio-blk child refcount in transports, Stefan Hajnoczi, 2014/05/30