Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

[Alexey Kardashevskiy]

On 06/04/2014 07:16 PM, Peter Maydell wrote:
> On 4 June 2014 09:08, Alexey Kardashevskiy <address@hidden> wrote:
>> This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are supported.
>>
>> The change to existing behaviour is that x86 only delivers NMI to
>> the current monitored CPU now, not to every CPU.
> 
> So this series means that the "nmi" command and handler does
>  * NMI on x86
>  * reset on PPC

The vector is called "reset" but it is an interrupt, and I do not see any
way to mask it.

>  * restart on S390

The vector is called "restart" but it is still an interrupt.


> That doesn't seem generic at all, and suggests this should
> not be a common CPU method/callback.

Oh. Ok. Suggestions?


-- 
Alexey