Re: [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts

[Chun Yan Liu]

>>> On 6/4/2014 at 05:18 PM, in message
<address@hidden>, Stefan Hajnoczi
<address@hidden> wrote: 
> On Wed, May 07, 2014 at 05:58:25PM +0800, Chunyan Liu wrote: 
> > This patch series is to replace QEMUOptionParameter with QemuOpts, so that  
> only 
> > one Qemu Option structure is kept in QEMU code. 
> >  
> > --- 
> > Changes to v26: 
> >   * Following Eric's comment, backward split 2/33, 3/33. 
> >     (repurpose qemu_opts_print first, add def_value_str to QemuOptDesc  
> later). 
> >   * Fix memory free in qemu_opts_append to solve iotest issue. 10/33 
> >   * Following Eric's comment, remove the end '.' in error message. And  
> update 
> >     qemu-iotests .out file. 12/33 
> >   * Following Eric's comment, fix memory free in vvfat.c 13/33 
> >   * Following Eric's comment, split qcow2 patch into two. 19/33, 20/33: 
> >     export qemu_opt_find first, add qcow2 driver patch later. 
> >   * rebase to git master 
> >  
> > All patches are also available from: 
> > https://github.com/chunyanliu/qemu/commits/QemuOpts 
>  
> Please git rebase -x 'make && make check && make check-block' -i master: 
>  
> qemu-img.c: In function ‘print_block_option_help’: 
> qemu-img.c:289:36: error: ‘create_options’ undeclared (first use in this 
> function) 
>              free_option_parameters(create_options); 
>                                                ^ 
>  
>  
See. Code has been updated during this period of time since I sent the patch 
series
nearly a month ago. I'll rebase and resend. Thanks.

- Chunyan