Re: [Qemu-devel] [PATCH v27 07/33] QemuOpts: add qemu_opt_get_*_del functions for replace work

[Chun Yan Liu]

>>> On 6/4/2014 at 04:54 PM, in message
<address@hidden>, Stefan Hajnoczi
<address@hidden> wrote: 
> On Wed, May 07, 2014 at 05:58:32PM +0800, Chunyan Liu wrote: 
> > diff --git a/util/qemu-option.c b/util/qemu-option.c 
> > index 4d2d4d1..32e1d50 100644 
> > --- a/util/qemu-option.c 
> > +++ b/util/qemu-option.c 
> > @@ -575,6 +575,19 @@ static void qemu_opt_del(QemuOpt *opt) 
> >      g_free(opt); 
> >  } 
> >   
> > +/* qemu_opt_set allows many settings for the same option. 
> > + * This function deletes all settings for an option. 
> > + */ 
> > +static void qemu_opt_del_all(QemuOpts *opts, const char *name) 
> > +{ 
> > +    QemuOpt *opt, *next_opt; 
> > + 
> > +    QTAILQ_FOREACH_SAFE(opt, &opts->head, next, next_opt) { 
> > +        if (!strcmp(opt->name, name)) 
> > +            qemu_opt_del(opt); 
>  
> QEMU coding style always uses curlies, even when the if body is only one 
> statement.  Please use scripts/checkpatch.pl to scan your patches before 
> they are sent. 
>  
> I can fix this up while merging.  No need to resend. 
>  
>  

Since I need rebase, I'll update.
In fact I checked with scripts/checkpatch.pl but it doesn't report error or 
warning. :-(