[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Test BLOCK_JOB_READY event fo
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Test BLOCK_JOB_READY event for 0Kb image active commit |
|
Date: |
Thu, 5 Jun 2014 13:22:15 +0200 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jun 05, 2014 at 11:42:35AM +0800, Fam Zheng wrote:
> @@ -48,8 +49,11 @@ class ImageCommitTestCase(iotests.QMPTestCase):
> self.assert_qmp(event, 'data/device', 'drive0')
> self.assert_qmp(event, 'data/offset', self.image_len)
> self.assert_qmp(event, 'data/len', self.image_len)
> + if need_ready:
> + assert ready, "Expceting BLOCK_JOB_COMPLETED event"
s/Expceting/Expecting/
Please use TestCase.assert*() methods instead of the assert keyword:
self.assertTrue(ready, msg='Expecting BLOCK_JOB_COMPLETED event')
The assert keyword raises the built-in AssertionError, which may not be
supported by the unittest module:
https://docs.python.org/2/library/unittest.html