Re: [Qemu-devel] [PATCH] rbd: Fix leaks in rbd_start_aio() error path

[Benoît Canet]

The Thursday 05 Jun 2014 à 15:55:27 (+0200), Kevin Wolf wrote :
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/rbd.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/block/rbd.c b/block/rbd.c
> index 09af484..94e2bfd 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -684,13 +684,16 @@ static BlockDriverAIOCB *rbd_start_aio(BlockDriverState 
> *bs,
>      }
>  
>      if (r < 0) {
> -        goto failed;
> +        goto failed_completion;
>      }
>  
>      return &acb->common;
>  
> +failed_completion:
> +    rbd_aio_release(c);
>  failed:
>      g_free(rcb);
> +    g_free(acb->bounce);

Err, Isn't it blockaligned ? (qemu_vfree) ?
>      qemu_aio_release(acb);
>      return NULL;
>  }
> -- 
> 1.8.3.1
> 
>