[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl.c: Check -smp option ranges before setting i
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] vl.c: Check -smp option ranges before setting int globals |
|
Date: |
Fri, 06 Jun 2014 08:06:52 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eduardo Habkost <address@hidden> writes:
> When parsing the -smp option, check if the values (that can be anywhere
> in the [0, UINT64_MAX] range) are in the int range before setting the
> int globals smp_cpus, max_cpus, smp_cores, smp_threads.
>
> Without this, it was posbible to make smp_cpus and max_cpus negative.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
The INT_MAX limit might be too generous, but your code sure beats the
silent truncation we have now.
Reviewed-by: Markus Armbruster <address@hidden>