[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set |
Date: |
Fri, 6 Jun 2014 22:26:15 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
It would be much better if we didn't terminate QEMU inside
device_post_init(), but at least exiting cleanly is better than aborting
and dumping core.
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/core/qdev.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index e65a5aa..74862c2 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -901,7 +901,13 @@ static void device_initfn(Object *obj)
static void device_post_init(Object *obj)
{
- qdev_prop_set_globals(DEVICE(obj), &error_abort);
+ Error *err = NULL;
+ qdev_prop_set_globals(DEVICE(obj), &err);
+ if (err) {
+ qerror_report_err(err);
+ error_free(err);
+ exit(EXIT_FAILURE);
+ }
}
/* Unlink device from bus and free the structure. */
--
1.9.0
- [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Eduardo Habkost, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Don Slutz, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Igor Mammedov, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Eduardo Habkost, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Igor Mammedov, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Peter Maydell, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Eduardo Habkost, 2014/06/06
- [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set,
Eduardo Habkost <=
- Re: [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set, Michael S. Tsirkin, 2014/06/08
- Re: [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set, Igor Mammedov, 2014/06/09
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Peter Maydell, 2014/06/07