qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/9 v3] FreeBSD-user: Implement print_sysctl() s


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 3/9 v3] FreeBSD-user: Implement print_sysctl() syscall
Date: Sat, 7 Jun 2014 22:58:39 +0100

On 6 June 2014 14:49, Sean Bruno <address@hidden> wrote:

Your commit message is inaccurate -- this patch isn't
implementing a syscall, it's just adding support to QEMU's
strace code for it. Something like
"bsd-user: Implement strace support for 'syscall' syscall"

would be better.

If you fix that, then
Reviewed-by: Peter Maydell <address@hidden>

(I notice you haven't put in a Copyright: line when you added
the file header, but I'm a bit unconvinced that they're really
useful for anything so I think that's ok.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]