Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev

[Paolo Bonzini]

Il 09/06/2014 15:32, Igor Mammedov ha scritto:
> > > > > > >> > +{ 'command': 'query-memdev', 'returns': ['Memdev'] }
> > > > > Could we make it union, that returns MemdevRam + MemdevFile
> > > > >
> > > > > MemdevFile will have additional file-only specific properties.
> > > > >
> > >
> > > Which are the file-only properties (in the current definition of Memdev)?
> in current none, but for file backend exposing 'path' property might be useful
> alternatively instead of union we could add 'type' and optional 'path' fields
> to Memdev

Yes, I agree.  I think the latest additions to QAPI actually let you do 
that with a QAPI union while keeping backwards-compatible output for 
other fields.  Ok to do this later?  It should be acceptable for soft 
freeze.

Paolo