Re: [Qemu-devel] [PATCH v2 2/4] mirror: Go through ready -> complete process for 0 len image

[Eric Blake]

On 06/08/2014 08:56 PM, Fam Zheng wrote:
> When mirroring or active committing a zero length image, BLOCK_JOB_READY
> is not reported now, instead the job completes because we short circuit
> the mirror job loop.
> 
> This is inconsistent with non-zero length images, and only confuses
> management software.
> 
> Let's do the same thing when seeing a 0-length image: report ready
> immediately; wait for block-job-cancel or block-job-complete; clear the
> cancel flag as existing non-zero image synced case (cancelled after
> ready); then jump to the exit.
> 
> Reported-by: Eric Blake <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  block/mirror.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature