[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] char: fix avail_connections init in qemu_chr
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] char: fix avail_connections init in qemu_chr_open_eventfd() |
|
Date: |
Thu, 12 Jun 2014 11:10:19 +0200 |
On Mi, 2014-06-11 at 17:25 +0200, David Marchand wrote:
> When trying to use a ivshmem server with qemu, ivshmem init code tries to
> create a CharDriverState object for each eventfd retrieved from the server.
> To create this object, a call to qemu_chr_open_eventfd() is done.
> Right after this, before adding a frontend, qemu_chr_fe_claim_no_fail() is
> called.
> qemu_chr_open_eventfd() does not set avail_connections to 1, so no frontend
> can
> be associated because qemu_chr_fe_claim_no_fail() makes qemu stop right away.
>
> This problem comes from 456d60692310e7ac25cf822cc1e98192ad636ece
> "qemu-char: Call fe_claim / fe_release when not using qdev chr properties".
>
> Fix this, by setting avail_connections to 1 in qemu_chr_open_eventfd().
>
> Signed-off-by: David Marchand <address@hidden>
Picked up.
cheers,
Gerd