qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in wav_fi


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in wav_fini_out()
Date: Thu, 12 Jun 2014 12:31:39 +0200

  Hi,

> >   doclose:
> >      if (fclose (wav->f))  {
> > -        dolog ("wav_fini_out: fclose %p failed\nReason: %s\n",
> > -               wav->f, strerror (errno));
> > +        dolog ("wav_fini_out: fclose 'wav->f' failed\nReason: %s\n",
> > +              strerror (errno));
> 
> I would just drop the 'wav->f' here.

Or drop the whole message?  It's a highly unlikely error condition after
all, and we can't do much about it anyway.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]