[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH applied] ich: get rid of spaces in type name
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH applied] ich: get rid of spaces in type name |
Date: |
Thu, 12 Jun 2014 16:33:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> writes:
> On Thu, Jun 12, 2014 at 10:27:53AM +0200, Markus Armbruster wrote:
>> "Michael S. Tsirkin" <address@hidden> writes:
>>
>> > Names with spaces in them are nasty, let's not go there.
>>
>> Yes, they are, but please use '-' instead of '_'. I can see just a few
>> devices with '_' in their name, but more than a hundred with '-'.
>
> No problem, I made this change.
> Result pushed to the pci branch, pls take a look there.
>
> Thanks!
The change is good, but I have more questions now.
What about "ICH9 SMB" in hw/i2c/smbus_ich9.c?
Technically, device names are ABI. These two are onboard devices, so
changing their names can't break -device / device_add use. It still
could break -global use. Do we care?
If yes, the obvious fix is to keep the old name as alias.