qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 12/22] target-mips: add ALIGN, DALIGN, BITSWA


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 12/22] target-mips: add ALIGN, DALIGN, BITSWAP and DBITSWAP instructions
Date: Thu, 12 Jun 2014 07:34:08 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 06/12/2014 01:35 AM, Leon Alrae wrote:
> Yes, it clutters the code a bit. However, by looking at the other
> instructions I got the impression that preferable approach is to avoid
> generating unnecessary code if we can. This seems to be sensible so I'm
> trying to stick to it. So in bitswap example I think there is no point
> in calling the helper if we know that the result will be 0.

On the other hand, for certain values of never that exclude conformance testing
software, one will never see r0 as input to bswap.  So it's still a useless
optimization.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]