Re: [Qemu-devel] [PATCH V6 04/29] test: add test cases for qapi event

[Eric Blake]

On 06/05/2014 06:21 AM, Wenchao Xia wrote:
> These cases will verify whether the expected qdict is built.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  tests/Makefile                          |   16 ++-
>  tests/qapi-schema/qapi-schema-test.json |   12 ++
>  tests/qapi-schema/qapi-schema-test.out  |   10 +-
>  tests/test-qmp-event.c                  |  265 
> +++++++++++++++++++++++++++++++
>  4 files changed, 298 insertions(+), 5 deletions(-)
>  create mode 100644 tests/test-qmp-event.c
> 


> +
> +    /* Verify that we have timestamp, then remove it to compare other field 
> */

s/field/fields/

Minor enough to include that as part of your followup patch to the whole
series.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature