Re: [Qemu-devel] [PATCH V6 09/29] qapi event: convert POWERDOWN

[Eric Blake]

On 06/05/2014 06:22 AM, Wenchao Xia wrote:
> There is no existing comments for POWERDOWN in doc/qmp/qmp-events.txt,
> so no change on it like other conversion patch.

Oddly enough, POWERDOWN _is_ documented in docs/qmp/qmp-spec.txt, but
that reference doesn't need updating with this conversion.

> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  qapi-event.json |   10 ++++++++++
>  vl.c            |    2 +-
>  2 files changed, 11 insertions(+), 1 deletions(-)

> +++ b/vl.c
> @@ -1991,7 +1991,7 @@ void qemu_system_shutdown_request(void)
>  
>  static void qemu_system_powerdown(void)
>  {
> -    monitor_protocol_event(QEVENT_POWERDOWN, NULL);
> +    qapi_event_send_powerdown(NULL);

Modulo my comment in 8/29 on whether we even need an errp argument,

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature