Re: [Qemu-devel] [PATCH 3/3] target-arm/translate-a64.c: Fix dead ?: in handle_simd_shift_fpint_conv()

[Peter Crosthwaite]

On Sun, Jun 8, 2014 at 6:11 AM, Peter Maydell <address@hidden> wrote:
> In handle_simd_shift_fpint_conv(), the combination of is_double == true,
> is_scalar == false and is_q == false is an unallocated encoding; the
> 'both parts false' case of the nested ?: expression for calculating
> maxpass is therefore unreachable and can be removed.
>
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
>  target-arm/translate-a64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 4c9e237..5542d7d 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -6484,7 +6484,7 @@ static void handle_simd_shift_fpint_conv(DisasContext 
> *s, bool is_scalar,
>      tcg_shift = tcg_const_i32(fracbits);
>
>      if (is_double) {
> -        int maxpass = is_scalar ? 1 : is_q ? 2 : 1;
> +        int maxpass = is_scalar ? 1 : 2;
>
>          for (pass = 0; pass < maxpass; pass++) {
>              TCGv_i64 tcg_op = tcg_temp_new_i64();
> --
> 1.8.5.4
>
>