Re: [Qemu-devel] [PATCH v3 00/18] migration: add static analysis tool to check vmstate compat

[Eric Blake]

On 06/17/2014 07:59 AM, Amit Shah wrote:
> On (Tue) 17 Jun 2014 [07:34:07], Eric Blake wrote:
>>
>>
>> On 06/17/2014 07:19 AM, Amit Shah wrote:
>>> Hello,
>>>
>>> v3:
>>>  - Python script returns an error code: 0 if no errors, positive for
>>>    the number of errors identified.
>>
>> Returning the error count as $? is unreliable - if you have exactly 256
>> errors, that gives the same status as if you had success.  Does your
>> code guarantee non-zero return in that case?
> 
> No; any good ideas for this, then?  Just limit to 255, and never bump
> upwards?

Yes, saturating math (capping at 255) is sufficient; in the normal case,
we won't have that many errors.

> 
> I'm only introducing this so that future integration with 'make check'
> can be noticed by scripts.

And for that, all we need is a non-zero status.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature