Re: [Qemu-devel] [PATCH] taget-i386: Broadwell CPU model

[Eduardo Habkost]

On Tue, Jun 17, 2014 at 10:34:16PM +0200, Andreas Färber wrote:
[...]
> > +        .features[FEAT_1_EDX] =
> > +            CPUID_SSE2 | CPUID_SSE | CPUID_FXSR | CPUID_MMX |
> > +             CPUID_CLFLUSH | CPUID_PSE36 | CPUID_PAT | CPUID_CMOV | 
> > CPUID_MCA |
> > +             CPUID_PGE | CPUID_MTRR | CPUID_SEP | CPUID_APIC | CPUID_CX8 |
> > +             CPUID_MCE | CPUID_PAE | CPUID_MSR | CPUID_TSC | CPUID_PSE |
> > +             CPUID_DE | CPUID_FP87,
> 
> The indentation looks inconsistent (1 off), although I don't see a tab
> character in the mix...

This was copied & pasted from the Haswell CPU model. I hadn't noticed
it.

Now I see that all CPU models starting from Conroe have the same
indentation inconsistency. Worth fixing on all CPU models before sending
a pull request, I guess.


> > +        .features[FEAT_1_ECX] =
> > +            CPUID_EXT_AVX | CPUID_EXT_XSAVE | CPUID_EXT_AES |
> > +             CPUID_EXT_POPCNT | CPUID_EXT_X2APIC | CPUID_EXT_SSE42 |
> > +             CPUID_EXT_SSE41 | CPUID_EXT_CX16 | CPUID_EXT_SSSE3 |
> > +             CPUID_EXT_PCLMULQDQ | CPUID_EXT_SSE3 |
> > +             CPUID_EXT_TSC_DEADLINE_TIMER | CPUID_EXT_FMA | 
> > CPUID_EXT_MOVBE |
> > +             CPUID_EXT_PCID,
> > +        .features[FEAT_8000_0001_EDX] =
> > +            CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_EXT2_NX |
> > +             CPUID_EXT2_SYSCALL,
> > +        .features[FEAT_8000_0001_ECX] =
> > +            CPUID_EXT3_LAHF_LM | CPUID_EXT3_3DNOWPREFETCH,
> > +        .features[FEAT_7_0_EBX] =
> > +            CPUID_7_0_EBX_FSGSBASE | CPUID_7_0_EBX_BMI1 |
> > +            CPUID_7_0_EBX_HLE | CPUID_7_0_EBX_AVX2 | CPUID_7_0_EBX_SMEP |
> > +            CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ERMS | 
> > CPUID_7_0_EBX_INVPCID |
> > +            CPUID_7_0_EBX_RTM | CPUID_7_0_EBX_RDSEED | CPUID_7_0_EBX_ADX |
> > +            CPUID_7_0_EBX_SMAP,
> > +        .xlevel = 0x8000000A,
> > +        .model_id = "Intel Core Processor (Broadwell)",
> > +    },
> > +    {
> >          .name = "Opteron_G1",
> >          .level = 5,
> >          .vendor = CPUID_VENDOR_AMD,
> 
> Apart from that, looks sane, so if someone can confirm the
> Broadwell-specific values I'll be happy to fix the style and queue it
> for 2.1.

I hope the Intel folks that are on CC can give a Reviewed-by and/or
Tested-by tag.

Thanks!

-- 
Eduardo