qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 12/18] target-i386: Support check/enforce fla


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v4 12/18] target-i386: Support check/enforce flags in TCG mode, too
Date: Wed, 18 Jun 2014 17:54:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 18/06/2014 17:50, Andreas Färber ha scritto:
>> +    } else if (tcg_enabled()) {
>>          return wi->tcg_features;
>> +    } else {
>> +        return UINT32_MAX;
>
> Agreed, but I would prefer writing it as ~0 instead of UINT32_MAX.
FTR done as ~0u to avoid any signedness issues.


FWIW, I find ~0u worse than ~0, because the former expands to 0xffffffff if x86_cpu_get_supported_feature_word is ever changed to return uint64_t. The latter instead returns all-ones as desired.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]