Re: [Qemu-devel] [PATCH block v1 1/2] block: m25p80: sync_page(): Deindent function body.

[Stefan Hajnoczi]

On Wed, Jun 18, 2014 at 06:36:03PM -0700, Peter Crosthwaite wrote:
> sync_page() was conditionalizing it's whole fn body on the bdrv being
> non-null. Just return for the function immediately on NULL brdv and
> get rid of the big if.
> 
> Makes implementation consistent with flash_zynq_area().
> 
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> 
>  hw/block/m25p80.c | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)

I don't know the hardware in question but from a block layer standpoint,
this series is fine.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

pgpQVGK_TtpVx.pgp
Description: PGP signature