Re: [Qemu-devel] [PATCH 2.1 29/36] qapi event: convert QUORUM events

[Eric Blake]

On 06/18/2014 12:43 AM, Paolo Bonzini wrote:
> From: Wenchao Xia <address@hidden>
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---

> +++ b/monitor.c
> @@ -617,6 +617,9 @@ static void monitor_qapi_event_init(void)
>      monitor_qapi_event_throttle(QAPI_EVENT_RTC_CHANGE, 1000);
>      monitor_qapi_event_throttle(QAPI_EVENT_WATCHDOG, 1000);
>      monitor_qapi_event_throttle(QAPI_EVENT_BALLOON_CHANGE, 1000);
> +    /* limit the rate of quorum events to avoid hammering the management */
> +    monitor_qapi_event_throttle(QAPI_EVENT_QUORUM_REPORT_BAD, 1000);

You could drop this comment; the one several lines earlier states pretty
much the same thing.  But saving it for a followup is okay with me.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature