Re: [Qemu-devel] [PATCH v10 0/4] Quorum maintainance operations

[Stefan Hajnoczi]

On Mon, Jun 16, 2014 at 12:00:53PM +0200, Benoît Canet wrote:
> in v10:
>         address max comments
> 
> Benoît Canet (4):
>   quorum: Add the rewrite-corrupted parameter to quorum
>   block: Add node-name argument to drive-mirror
>   block: Add replaces argument to drive-mirror
>   qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror
>     node-name mode.
> 
>  block.c                    |  17 ++++
>  block/mirror.c             |  60 +++++++++++---
>  block/quorum.c             |  97 ++++++++++++++++++++--
>  blockdev.c                 |  41 +++++++++-
>  hmp.c                      |   1 +
>  include/block/block.h      |   4 +
>  include/block/block_int.h  |   3 +
>  qapi/block-core.json       |  13 ++-
>  qmp-commands.hx            |   5 ++
>  tests/qemu-iotests/041     | 196 
> ++++++++++++++++++++++++++++++++++++++++++++-
>  tests/qemu-iotests/041.out |   4 +-
>  tests/qemu-iotests/081     |  15 +++-
>  tests/qemu-iotests/081.out |  10 +++
>  13 files changed, 436 insertions(+), 30 deletions(-)

I'm happy with this but need to review Jeff's series first.  Your series
assumes that nodes are protected by op blockers, which they currently
aren't (only the root node has op blockers).  So we need a solution to
that before it's safe to allow operations on nodes - I think Jeff's
series tackles that.

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgpNWKwIh6jOe.pgp
Description: PGP signature