[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain dri
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers |
|
Date: |
Thu, 19 Jun 2014 14:24:36 +0800 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Jun 18, 2014 at 12:14:08AM +0200, Max Reitz wrote:
> For some protocol block drivers, the "filename" attribute in their BDSs
> is unset due to bdrv_file_open() removing it from the options QDict
> before bdrv_open_common() is able to copy it into the BDS. Fix this by
> not removing it until until bdrv_open_common() has indeed copied it.
>
>
> Max Reitz (2):
> block: Do not prematurely remove "filename"
> iotests: Add test for set "filename" for NBD
>
> block.c | 12 ++++++--
> tests/qemu-iotests/097 | 72
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/097.out | 13 +++++++++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 95 insertions(+), 3 deletions(-)
> create mode 100755 tests/qemu-iotests/097
> create mode 100644 tests/qemu-iotests/097.out
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpt2goVMH7nF.pgp
Description: PGP signature