[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2.1 31/36] qemu-char: introduce qemu_chr_alloc
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2.1 31/36] qemu-char: introduce qemu_chr_alloc |
Date: |
Thu, 19 Jun 2014 06:03:35 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/18/2014 12:43 AM, Paolo Bonzini wrote:
> The next patch will modify this function to initialize state that is
> common to all backends.
>
> Reviewed-by: Fam Zheng <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> backends/baum.c | 2 +-
> backends/msmouse.c | 2 +-
> include/sysemu/char.h | 9 +++++++++
> qemu-char.c | 32 +++++++++++++++++++-------------
> spice-qemu-char.c | 2 +-
> ui/console.c | 2 +-
> 6 files changed, 32 insertions(+), 17 deletions(-)
Missing hw/misc/ivshmem.c:
static int pci_ivshmem_init(PCIDevice *dev)
{
...
s->eventfd_chr = g_malloc0(s->vectors * sizeof(CharDriverState *));
qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
ivshmem_read,
ivshmem_event, s);
Is that going to matter? If not,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2.1 30/36] qapi event: clean up, (continued)
[Qemu-devel] [PATCH 2.1 32/36] qemu-char: do not call chr_write directly, Paolo Bonzini, 2014/06/18
[Qemu-devel] [PATCH 2.1 33/36] qemu-char: move pty_chr_update_read_handler around, Paolo Bonzini, 2014/06/18
[Qemu-devel] [PATCH 2.1 35/36] monitor: protect outbuf and mux_out with mutex, Paolo Bonzini, 2014/06/18
[Qemu-devel] [PATCH 2.1 34/36] qemu-char: make writes thread-safe, Paolo Bonzini, 2014/06/18
[Qemu-devel] [PATCH 2.1 36/36] monitor: protect event emission, Paolo Bonzini, 2014/06/18
Message not available
- Re: [Qemu-devel] [PATCH 2.1 31/36] qemu-char: introduce qemu_chr_alloc,
Eric Blake <=
Re: [Qemu-devel] [PATCH 2.1 00/36] Pending monitor patches for 2.1, Luiz Capitulino, 2014/06/19
Re: [Qemu-devel] [PATCH 2.1 00/36] Pending monitor patches for 2.1, Eric Blake, 2014/06/20
Re: [Qemu-devel] [PATCH 2.1 00/36] Pending monitor patches for 2.1, Markus Armbruster, 2014/06/26