Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

[Gerd Hoffmann]

On Do, 2014-06-19 at 14:24 +0200, Andreas Färber wrote:
> Hi Gerd,
> 
> Am 19.06.2014 12:05, schrieb Gerd Hoffmann:
> >> Gonglei (5):
> >>   tests: add OHCI qtest
> >>   tests: add UHCI qtest
> >>   tests: add xHCI qtest
> >>   usb-hcd-ehci-test: change ehci qtest more expansively
> >>   usb-hcd-ehci-test: add ehci hotplug/unplug qtest
> > 
> > I'd prefer to leave the usb-hcd-ehci-test alone.
> 
> Why? My idea was to put all EHCI testing code into that ehci file. This
> is so that any defines or helper functions can be shared within the
> file. Functional testing of the companion core should go into the
> respective *hci file, unless there is some interaction to test.

The hotplugging and the tests currently in usb-hcd-ehci-test are quite
different.  Hotplugging creates a empty machine, then plugs + unplugs
stuff.  usb-hcd-ehci-test creates a machine with ehci+ohci companions,
then goes run a bunch of tests for it.

Maybe it makes sense to have a usb-hcd-hotplug-test.c file and collect
hotplug testing for all usb hcds we have there.  For code sharing
that'll be better for sure as the basic code flow is the same for all
hcd types.

cheers,
  Gerd