[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi/hmp: use 'backend' instead of 'device' wit
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] qapi/hmp: use 'backend' instead of 'device' with memory backend |
|
Date: |
Thu, 19 Jun 2014 07:41:29 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/19/2014 07:37 AM, Igor Mammedov wrote:
> fixup documentation comments and HMP message/help text
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> PS: based on PCI tree
> ---
> hmp.c | 2 +-
> monitor.c | 2 +-
> qapi-schema.json | 11 ++++++-----
> 3 files changed, 8 insertions(+), 7 deletions(-)
>
> # Since: 2.1
> ##
> { 'command': 'query-memdev', 'returns': ['Memdev'] }
> +
> # @PCDIMMDeviceInfo:
Can you also add a ## lead-in to PCDIMMDeviceInfo? The rest of the file
is fairly consistent at:
##
# docs
##
{ ... }
With that line added,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature