qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat


From: Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16
Date: Sat, 21 Jun 2014 22:29:33 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Sat, Jun 21, 2014 at 09:06:21PM +0100, Peter Maydell wrote:
> On 21 June 2014 20:35, Aurelien Jarno <address@hidden> wrote:
> > The roundAndPackFloat16 function should return a float16 value, not a
> > float32 one. Fix that.
> >
> > Cc: Peter Maydell <address@hidden>
> > Signed-off-by: Aurelien Jarno <address@hidden>
> 
> Agreed, though I don't think it has any effect on the results.

No, it doesn't have any effect on the results, but it produces slightly
less optimized code. The main problem there is that it fails to build
when enforcing type checking, though less and less targets are compiling
when it is enabled.

> Can we have the usual "ok under softfloat 2a or 2b license"
> confirmation, please?

Yes, I am fine to license this patch under softfloat 2a or 2b license.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]