qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for setti


From: Paul Burton
Subject: Re: [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for settimeofday
Date: Sun, 22 Jun 2014 11:11:04 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Sun, Jun 22, 2014 at 12:18:02AM +0100, Peter Maydell wrote:
> > +    if (!lock_user_struct(VERIFY_READ, target_tz, target_tz_addr, 1))
> > +        return -TARGET_EFAULT;
> 
> Coding style mandates braces even on single-line if()s; checkpatch.pl
> will catch this usually.

I copied that style from the equivalent timeval functions, but yeah I'll
make sure to get into the habit of running checkpatch for QEMU patches.

> Code looks OK otherwise.

Thanks for looking,
    Paul

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]