qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9] net: L2TPv3 transport


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v9] net: L2TPv3 transport
Date: Mon, 23 Jun 2014 19:50:17 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Jun 20, 2014 at 10:34:41AM +0100, address@hidden wrote:
> From: Anton Ivanov <address@hidden>
> 
> This transport allows to connect a QEMU nic to a static Ethernet
> over L2TPv3 tunnel. The transport supports all options present
> in the Linux kernel implementation. It allows QEMU to connect
> to any Linux host running kernel 3.3+, most routers and network
> devices as well as other QEMU instances.
> 
> Signed-off-by: Anton Ivanov <address@hidden>
> ---
> 
> Comments addressed in this patch:
> 
> 1. Extra checks and reinitilization of the result variable in init to
> address remaining potential failure cases in getaddrinfo() as noticed 
> by Stefan Hajnoczi
> 
>  net/Makefile.objs |    1 +
>  net/clients.h     |    2 +
>  net/l2tpv3.c      |  757 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  net/net.c         |    3 +
>  qapi-schema.json  |   60 +++++
>  qemu-options.hx   |   82 ++++++
>  6 files changed, 905 insertions(+)
>  create mode 100644 net/l2tpv3.c

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Note I had to add the following to make -netdev work:
@@ -842,6 +845,9 @@ static int net_client_init1(const void *object, int 
is_netdev, Error **errp)
 #ifdef CONFIG_VHOST_NET_USED
         case NET_CLIENT_OPTIONS_KIND_VHOST_USER:
 #endif
+#ifdef CONFIG_LINUX
+        case NET_CLIENT_OPTIONS_KIND_L2TPV3:
+#endif
             break;
 
         default:

Stefan

Attachment: pgpi4z0q45ZI6.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]